-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump dagstore #2602
Merged
distractedm1nd
merged 2 commits into
celestiaorg:main
from
walldiss:bump-dagstore-remove-mmap
Aug 24, 2023
Merged
chore(deps): bump dagstore #2602
distractedm1nd
merged 2 commits into
celestiaorg:main
from
walldiss:bump-dagstore-remove-mmap
Aug 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walldiss
requested review from
renaynay,
Wondertan,
vgonkivs and
distractedm1nd
as code owners
August 23, 2023 16:57
Wondertan
reviewed
Aug 23, 2023
walldiss
force-pushed
the
bump-dagstore-remove-mmap
branch
from
August 23, 2023 17:00
800f585
to
0f3e6a2
Compare
Wondertan
previously approved these changes
Aug 23, 2023
Codecov Report
@@ Coverage Diff @@
## main #2602 +/- ##
==========================================
+ Coverage 51.16% 51.23% +0.07%
==========================================
Files 158 158
Lines 10512 10512
==========================================
+ Hits 5378 5386 +8
+ Misses 4658 4651 -7
+ Partials 476 475 -1 |
We have to bump dagstore again so don't approve this PR until vlad is awake (its on automerge) |
It is ready now. |
Wondertan
approved these changes
Aug 24, 2023
distractedm1nd
approved these changes
Aug 24, 2023
walldiss
added a commit
to walldiss/celestia-node
that referenced
this pull request
Sep 22, 2023
Updating dagstore should fix the issue with panic of mmap on bitswap reads. (cherry picked from commit 440e232)
walldiss
added a commit
that referenced
this pull request
Sep 22, 2023
Updating dagstore should fix the issue with panic of mmap on bitswap reads. (cherry picked from commit 440e232)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating dagstore should fix the issue with panic of mmap on bitswap reads.